Skip to content

test(e2e): Fix type error in nextjs ai-error tests - #22978

Merged
chargome merged 1 commit into
developfrom
charlygomez/js-3258-nextjs-16-canary-test-failed
Aug 4, 2026
Merged

test(e2e): Fix type error in nextjs ai-error tests#22978
chargome merged 1 commit into
developfrom
charlygomez/js-3258-nextjs-16-canary-test-failed

Conversation

@chargome

@chargome chargome commented Aug 4, 2026 •
edited by nicohrubec
Loading

Copy link
Copy Markdown
Member

Fixes a build-time type error that breaks the nextjs-16 canary and latest E2E jobs.

Next 16.3 flipped experimental.useTypeScriptCli to true by default, and unlike the previous TypeScript-API path it does not filter diagnostics in *.(spec|test).* files, so this pre-existing error now fails next build.

closes #22973
closes #22974

@chargome @claude
test(e2e): Fix type error in nextjs ai-error tests
5fe5f8a 
`value?.includes(...)` yields `boolean | undefined`, which widens to
`Promise<boolean | undefined>` in the async callback and is not assignable to
`waitForError`'s `boolean | Promise<boolean>`.

Next 16.3 made `experimental.useTypeScriptCli` the default, and that path does
not filter diagnostics in `*.test.ts` the way the previous TypeScript-API path
did, so this pre-existing error now fails `next build`.

Fixes #22973

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@linear-code

linear-code Bot commented Aug 4, 2026

Copy link
Copy Markdown

JS-3258

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.91 kB - -
@sentry/browser - with treeshaking flags 28.12 kB - -
@sentry/browser (incl. Tracing) 47.36 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.36 kB - -
@sentry/browser (incl. Tracing, Profiling) 52.13 kB - -
@sentry/browser (incl. Tracing, Replay) 86.7 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.13 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.41 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 104.05 kB - -
@sentry/browser (incl. Feedback) 47.22 kB - -
@sentry/browser (incl. sendFeedback) 34.76 kB - -
@sentry/browser (incl. FeedbackAsync) 39.87 kB - -
@sentry/browser (incl. Metrics) 30.99 kB - -
@sentry/browser (incl. Logs) 31.22 kB - -
@sentry/browser (incl. Metrics & Logs) 31.9 kB - -
@sentry/react 31.73 kB - -
@sentry/react (incl. Tracing) 49.61 kB - -
@sentry/vue 34.98 kB - -
@sentry/vue (incl. Tracing) 49.34 kB - -
@sentry/svelte 29.94 kB - -
CDN Bundle 32.01 kB - -
CDN Bundle (incl. Tracing) 47.72 kB - -
CDN Bundle (incl. Logs, Metrics) 33.55 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.08 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.9 kB - -
CDN Bundle (incl. Tracing, Replay) 85.35 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.65 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.14 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.46 kB - -
CDN Bundle - uncompressed 95.52 kB - -
CDN Bundle (incl. Tracing) - uncompressed 143.1 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.23 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 147.08 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 224.99 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 262.36 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 266.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 276.07 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 280.02 kB - -
@sentry/nextjs (client) 52.21 kB - -
@sentry/sveltekit (client) 47.81 kB - -
@sentry/core/server 80.01 kB - -
@sentry/core/browser 51.97 kB - -
@sentry/node 120.89 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 84.26 kB -0.01% -1 B 🔽
@sentry/aws-serverless 92.94 kB - -
@sentry/cloudflare (withSentry) - minified 219.37 kB - -
@sentry/cloudflare (withSentry) 540.47 kB - -

View base workflow run

@chargome chargome self-assigned this Aug 4, 2026
@chargome
chargome marked this pull request as ready for review August 4, 2026 08:56
@chargome
chargome requested review from Lms24 and nicohrubec August 4, 2026 08:56
@chargome
chargome merged commit 0fb78ac into develop Aug 4, 2026
50 checks passed
@chargome
chargome deleted the charlygomez/js-3258-nextjs-16-canary-test-failed branch August 4, 2026 09:06
This was referenced Aug 4, 2026
Merged
Merged
chargome added a commit that referenced this pull request Aug 4, 2026
@chargome
test(v10/e2e): Fix type error in nextjs ai-error tests (#23011)
a27251a 
Backport of: #22978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicohrubec nicohrubec nicohrubec approved these changes
@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@chargome chargome

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nextjs-16 (canary-webpack) Test Failed nextjs-16 (canary) Test Failed

2 participants

@chargome @nicohrubec